Skip to content

docs: add asqav governance and audit trail integration#5337

Open
jagmarques wants to merge 3 commits intocrewAIInc:mainfrom
jagmarques:docs/asqav-governance-integration
Open

docs: add asqav governance and audit trail integration#5337
jagmarques wants to merge 3 commits intocrewAIInc:mainfrom
jagmarques:docs/asqav-governance-integration

Conversation

@jagmarques
Copy link
Copy Markdown

Adds asqav as a governance tool integration. Covers the CrewAI callback hook for signed audit trails and the CI compliance scanner. PraisonAI merged the equivalent docs PR today (MervinPraison/PraisonAIDocs#55).

Adds a docs page for Asqav covering the AsqavCrewHook callback for
signed audit trails and the asqav-compliance CI scanner. Updates
docs.json navigation for all language versions.
@jagmarques
Copy link
Copy Markdown
Author

Note for maintainers: this PR was authored by an AI coding assistant (Claude Code). Please apply the llm-generated label per CONTRIBUTING.md.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ad14fabf69

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

agents=[researcher],
tasks=[task],
process=Process.sequential,
callbacks=[hook],
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Replace unsupported callbacks argument in Crew example

This snippet passes callbacks=[hook] to Crew(...), but Crew defines step_callback and task_callback (in lib/crewai/src/crewai/crew.py) and does not expose a callbacks field. In practice, users following this guide will think Asqav is wired in while the hook is never attached, so audit records are not captured as documented. Please switch the example to a supported Crew callback parameter so the integration actually executes.

Useful? React with 👍 / 👎.

- Use correct import path: asqav.extras.crewai (not asqav.integrations.crewai)
- Use correct constructor param: agent_name (not project)
- Use step_callback and task_callback instead of non-existent callbacks param
- Fix GitHub URL: github.com/asqav/asqav -> github.com/jagmarques/asqav-sdk
- Fix algorithm: Ed25519 -> ML-DSA-65 (server-side signing)
- Fix env var: ASQAV_SIGNING_KEY -> ASQAV_API_KEY
- Fix docs URLs: asqav.github.io/docs -> asqav.com/docs/integrations
- Remove hallucinated "asqav keygen" CLI command
- Remove hallucinated "asqav verify --log" CLI command
- Remove hallucinated "asqav-compliance scan" CI scanner section
- Remove hallucinated local JSONL logging (SDK doesn't write local files)
- Remove hallucinated audit log format section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant