Conversation
Transfer encoding responses don't have a `Content-Length` header. Currently, we severely overshoot the size since it counts the decompressed bytes. Instead, this PR switches to more reliable methods such as the resource timing API and re-compressing with leeway.
GODrums
approved these changes
Apr 9, 2026
Collaborator
GODrums
left a comment
There was a problem hiding this comment.
Complicated stuff, thanks for the comments!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transfer encoding responses don't have a
Content-Lengthheader. Currently, we severely overshoot the body size since it counts the decompressed bytes.Instead, this PR switches to more reliable methods such as the resource timing API and re-compressing with leeway.
Ref CSF-1322
Note
Medium Risk
Changes how
max_recv_datais estimated for chunked/gzipped responses; underestimation could cause notary/prover protocol failures, while overestimation mainly wastes headroom.Overview
Improves response size estimation in
calculateResponseSizewhenContent-Lengthis missing by switching fromblob.size(decompressed bytes) to a prioritized set of on-wire approximations.When no
Content-Lengthis present, it now consumes the body and estimates size via Resource TimingencodedBodySize(with padding), then re-gzipping viaCompressionStream(with leeway) when the response was gzip-encoded, and finally falls back to decompressed byte length; adds helper functionsgetEncodedBodySizeFromPerformanceandestimateGzipSizeand updates docs/debug logs accordingly.Reviewed by Cursor Bugbot for commit dfceef0. Bugbot is set up for automated code reviews on this repo. Configure here.