Implements FloatDB Gateway for Rank Fetching#387
Merged
Conversation
Prevents duplicate in-flight or cached requests from re-requesting ranks. Refactors the float fetcher service for performance.
there is no meaningful downside since pages are added incrementally as you paginate
GODrums
approved these changes
Apr 14, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d5562e7. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Overview
Switches to using the
gateway.floatdb.comservice to lookup ranks for items. There's been a decent chunk of optimization to reduce needless calls, such as using a threshold blob to determine whether an item qualifies for a rank.Changes
FetchInspectInfoBatchbridge method since the overhead of sending 100+ messages to the service worker to check ranks would exceed the rank batcher debounce interval.Ref CSF-1165
Note
Medium Risk
Introduces new networked rank-check and threshold-fetch flows plus request batching/deduping, which could affect item metadata/rank display correctness and increase reliance on the new gateway endpoints.
Overview
Switches rank lookups to the FloatDB Gateway (
environment.floatdb_gateway_url) and adds client-side rank-check batching plus local threshold caching to reduce unnecessary rank requests.Refactors float/inspect fetching to require
asset_idand to batch bridge calls via a newFETCH_INSPECT_INFO_BATCHhandler;FloatFetchernow microtask-batches, de-dupes in-flight requests, and caches results by asset.Adds eager prefetching of floats/ranks when inventory asset properties load, and updates market/inventory components to pass
asset_id(removing the previous list-price-based fetch path).Reviewed by Cursor Bugbot for commit 8204d10. Bugbot is set up for automated code reviews on this repo. Configure here.