Throttles Background Notary Proofs on Failure#388
Merged
Conversation
If a user is having issues with notary proofs, this PR prevents background rollback proofs for an hour after a failure. Ref CSF-753
GODrums
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user is having issues with notary proofs, this PR prevents re-requesting proofs for an hour after failure.
Alas, some users have horrid internet.
Ref CSF-753
Note
Low Risk
Low risk: small control-flow change that only gates background notary proving and persists a timestamp in local storage; main behavior still falls back to legacy rollback pings.
Overview
Rollback trade handling now throttles background notary proofs after a failure.
pingRollbackTradesrecords the last background notary proof failure inchrome.storage.localand skips re-attempting proofs for 60 minutes, immediately falling back to the legacyPingRollbackTradepath during that window.Adds a new storage key,
StorageKey.LAST_NOTARY_BG_PROOF_FAILURE, to persist the cooldown timestamp.Reviewed by Cursor Bugbot for commit be643fb. Bugbot is set up for automated code reviews on this repo. Configure here.