Apply source scope by default in any loader#191
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #191 +/- ##
============================================
- Coverage 94.48% 94.39% -0.10%
+ Complexity 937 936 -1
============================================
Files 81 81
Lines 2413 2409 -4
============================================
- Hits 2280 2274 -6
- Misses 133 135 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roxblnfk
approved these changes
Jun 22, 2021
Contributor
|
Please explain what usecase is covered by this change? https://github.com/cycle/orm/blob/master/src/Factory.php#L177 Scopes were attached by default at source level - so all repositories were reading them correctly. Select was created without a scope on purpose. |
Contributor
Author
I thought this more clear way to define scope on any loader, not just joinable. May be I get it wrong, but what is the purpose to not attach scope to select? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.