Skip to content
This repository was archived by the owner on Feb 18, 2026. It is now read-only.

mobile: daimo pay deposit webview#1395

Open
andrewliu08 wants to merge 3 commits intomasterfrom
andrew/dp-webview
Open

mobile: daimo pay deposit webview#1395
andrewliu08 wants to merge 3 commits intomasterfrom
andrew/dp-webview

Conversation

@andrewliu08
Copy link
Copy Markdown
Member

@andrewliu08 andrewliu08 commented Apr 19, 2025

Screen.Recording.2025-04-21.at.11.35.48.AM.mov

@andrewliu08 andrewliu08 requested a review from dcposch April 19, 2025 03:31
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
daimo-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2025 6:54pm

const [showDaimoPay, setShowDaimoPay] = useState(false);
const nav = useNav();

// Automatically close Daimo Pay webview when the user navigates away.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

const baseUrl = "http://localhost:3005/embed";
const params = new URLSearchParams({
toAddress: account.address,
refundAddress: "0xEEee8B1371f1664b7C2A8c111D6062b6576fA6f0", // daimo.eth
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be worth making a dedicated one

const handleMessage = useCallback(
(event: WebViewMessageEvent) => {
try {
const data = JSON.parse(event.nativeEvent.data);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommend logging data here

Copy link
Copy Markdown
Member

@dcposch dcposch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • fix lint
  • paste in a screenshot of the new deposit page

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants