Conversation
Add SessionPublicInfo.fees + UserFeeRule type. WalletAmountPage shows "Recipient gets $X" live when a user fee applies. WaitingDepositAddressPage shows "Recipient receives $X" subtitle for fixed-amount sessions with a fee. Sessions without a user fee render byte-identical to today. Pairs with daimo-eth/daimo-internal#1644. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionPublicInfo.feesandUserFeeRuleto the SDK types.WalletAmountPageshows live "Recipient gets $X" while typing/Max when a user fee applies; min floor bumped so the recipient still clears the chain minimum.WaitingDepositAddressPageshows "Recipient receives $X" subtitle for fixed-amount sessions with a fee.Pairs with the server side at daimo-eth/daimo-internal#1644.
Test plan
feesis unsetuserFee = { fixedUsd: 0.25, bps: 50 }: typing $100 shows "Recipient gets $99.25"recipientGets/recipientReceiveskeys🤖 Generated with Claude Code