harden qr center logo positioning against transform css mismatches#265
Open
harden qr center logo positioning against transform css mismatches#265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This changes the QR center logo from transform-based centering to layout-based centering.
Previously, the logo wrapper in the SDK used
left: 50%,top: 50%, andtranslate(-50%, -50%)to center the token/chain logo inside the QR. During investigation of a merchant report, we found that if that translate transform is missing or overridden, the logo shifts down and right in exactly the way shown in the client screenshot.This PR removes that dependency.
What changed
Why
The previous centering approach had a brittle failure mode:
left: 50%top: 50%transform: translate(-50%, -50%)If the transform rule disappears, is overridden, or comes from a mismatched CSS bundle, the logo becomes visibly misaligned.
Layout centering avoids depending on that transform rule for correct placement and should be more robust across merchant environments.
Verification
pnpm --filter @daimo/sdk buildpnpm --filter @daimo/pay-web typecheckAlso verified locally that:
Risk
Low. This is a UI-only hardening change with no API or behavior changes outside QR logo placement.