Skip to content

Fix #12742 FP containerOutOfBounds for increment in loop #8230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 3 commits into from
Feb 21, 2026
Merged

Fix #12742 FP containerOutOfBounds for increment in loop #8230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63d1511
Update valueflow.cpp
chrchr-github Feb 18, 2026
83c984a
Update teststl.cpp
chrchr-github Feb 18, 2026
1495c26
Format [skip ci]
chrchr-github Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/valueflow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4531,7 +4531,7 @@ struct ConditionHandler {
}

// Variable changed in loop code
const Token* const start = top;
const Token* const start = top->strAt(-1) == "for" ? top->astOperand2() : top; // skip init statement
const Token* const block = top->link()->next();
const Token* const end = block->link();

Expand Down
6 changes: 6 additions & 0 deletions test/teststl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1010,6 +1010,12 @@ class TestStl : public TestFixture {
ASSERT_EQUALS(
"[test.cpp:2:12] -> [test.cpp:4:21]: (warning) Either the condition 'col>textline.size()' is redundant or 'col' can have the value textline.size(). Expression 'textline[col]' causes access out of bounds. [containerOutOfBounds]\n",
errout_str());

check("void f(const std::vector<int>& v) {\n" // #12742
" for (unsigned i = 0; i < v.size();)\n"
" (void)v[i++];\n"
"}\n");
ASSERT_EQUALS("", errout_str());
}

void outOfBoundsIndexExpression() {
Expand Down