backport: Merge bitcoin#29227, 27389, 27832, 30215

[vijaydasmp]

bitcoin backporting

[github-actions]

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

[coderabbitai]

Walkthrough

This pull request updates JSON-RPC interface documentation and help text to use the correct application/json content-type header instead of text/plain across multiple files. The changes include updates to the documentation file, help text generation code, test assertions, and a related initialization argument help description. Additionally, the mempool loading process in validation.cpp now includes progress reporting in 10% increments. Minor refactoring is applied to binary data handling in functional tests, and test coverage for data carrier transactions is expanded with additional test scenarios.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the PR as a backport that merges four specific Bitcoin PRs (#29227, 27389, 27832, 30215), which aligns with the changeset containing documentation updates, help text changes, test refactoring, and mempool loading improvements.
Description check	✅ Passed	The description 'bitcoin backporting' is related to the changeset as the PR explicitly backports multiple upstream Bitcoin changes, though it lacks detail about the specific changes involved.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (3)

src/rpc/util.cpp (1)

222-234: Port number inconsistency between HelpExampleRpc and HelpExampleRpcNamed.

HelpExampleRpc on line 223 uses port 9998 (Dash mainnet RPC), while HelpExampleRpcNamed on line 234 uses port 8332 (Bitcoin mainnet RPC). This inconsistency appears to predate this PR but is worth noting since this code is being modified.

The content-type change from text/plain to application/json is correct for JSON-RPC requests.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/rpc/util.cpp` around lines 222 - 234, The two example helpers use
different hard-coded ports—HelpExampleRpc uses 9998 while HelpExampleRpcNamed
uses 8332—so make them consistent: either replace the 9998 in HelpExampleRpc
with 8332 to match HelpExampleRpcNamed, or (preferred) use the shared RPC port
constant/variable used elsewhere (instead of a literal) in both HelpExampleRpc
and HelpExampleRpcNamed so both examples always show the correct configured RPC
port.

test/functional/mempool_datacarrier.py (2)

33-36: Consider using list unpacking for cleaner syntax.

The type hint was removed to accommodate None, and the concatenation works correctly. However, using unpacking is more idiomatic Python.

Proposed changes

-    def test_null_data_transaction(self, node: TestNode, data, success: bool) -> None:
+    def test_null_data_transaction(self, node: TestNode, data: bytes | None, success: bool) -> None:
         tx = self.wallet.create_self_transfer(fee_rate=0)["tx"]
         data = [] if data is None else [data]
-        tx.vout.append(CTxOut(nValue=0, scriptPubKey=CScript([OP_RETURN] + data)))
+        tx.vout.append(CTxOut(nValue=0, scriptPubKey=CScript([OP_RETURN, *data])))

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/functional/mempool_datacarrier.py` around lines 33 - 36, The
test_null_data_transaction function currently builds the OP_RETURN script by
concatenating a list ([OP_RETURN] + data) after normalizing data to a list;
replace that concatenation with Python list unpacking to be more idiomatic: keep
the data normalization (data = [] if data is None else [data]) and construct the
CScript using CScript([OP_RETURN, *data]) when creating the CTxOut (refer to
test_null_data_transaction, tx.vout.append(CTxOut(...)), CScript and data
variables).

---

30-30: Remove extraneous f-string prefix.

This string has no placeholders, so the f prefix is unnecessary.

Proposed fix

-            ["-datacarrier=1", f"-datacarriersize=2"],
+            ["-datacarrier=1", "-datacarriersize=2"],

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/functional/mempool_datacarrier.py` at line 30, The second list element
uses an unnecessary f-string (f"-datacarriersize=2") even though there are no
placeholders; replace f"-datacarriersize=2" with a plain string
"-datacarriersize=2" in the list (e.g., change ["-datacarrier=1",
f"-datacarriersize=2"] to ["-datacarrier=1", "-datacarriersize=2"]).

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/rpc/util.cpp`:
- Around line 222-234: The two example helpers use different hard-coded
ports—HelpExampleRpc uses 9998 while HelpExampleRpcNamed uses 8332—so make them
consistent: either replace the 9998 in HelpExampleRpc with 8332 to match
HelpExampleRpcNamed, or (preferred) use the shared RPC port constant/variable
used elsewhere (instead of a literal) in both HelpExampleRpc and
HelpExampleRpcNamed so both examples always show the correct configured RPC
port.

In `@test/functional/mempool_datacarrier.py`:
- Around line 33-36: The test_null_data_transaction function currently builds
the OP_RETURN script by concatenating a list ([OP_RETURN] + data) after
normalizing data to a list; replace that concatenation with Python list
unpacking to be more idiomatic: keep the data normalization (data = [] if data
is None else [data]) and construct the CScript using CScript([OP_RETURN, *data])
when creating the CTxOut (refer to test_null_data_transaction,
tx.vout.append(CTxOut(...)), CScript and data variables).
- Line 30: The second list element uses an unnecessary f-string
(f"-datacarriersize=2") even though there are no placeholders; replace
f"-datacarriersize=2" with a plain string "-datacarriersize=2" in the list
(e.g., change ["-datacarrier=1", f"-datacarriersize=2"] to ["-datacarrier=1",
"-datacarriersize=2"]).

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 0120a33b-a7ca-4afc-a648-f0a6b9fa389c

📥 Commits

Reviewing files that changed from the base of the PR and between af926ae and 00f1792.

📒 Files selected for processing (7)

• doc/JSON-RPC-interface.md
• src/init.cpp
• src/rpc/util.cpp
• src/test/rpc_tests.cpp
• src/validation.cpp
• test/functional/interface_rest.py
• test/functional/mempool_datacarrier.py