lint: don't use lambdas for non-lambda stuff#3
Open
coolaj86 wants to merge 1 commit intodashpay:mainfrom
Open
Conversation
It's confusing to use mathematical lambdas where you're not returning a value or doing math
|
Arrow functions in JS could be used in any circumstances, there are no obligatory rules to return value or do the math. |
Author
Usefulness is not a great argument for code style.
There are many anti-semantic things you can do in JavaScript, but they're confusing and signal the wrong thing to the reader of the code. lambdas signal that you intend to return the evaluation of a mathematical expression in-line. That's what they're for. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's confusing to use mathematical lambdas where you're not returning a value or doing math