Skip to content

chore: update dashcore dependency in rs-platform-encryption to use workspace dep#3181

Open
ZocoLini wants to merge 1 commit intov3.1-devfrom
chore/fix-encryption-dep
Open

chore: update dashcore dependency in rs-platform-encryption to use workspace dep#3181
ZocoLini wants to merge 1 commit intov3.1-devfrom
chore/fix-encryption-dep

Conversation

@ZocoLini
Copy link
Collaborator

@ZocoLini ZocoLini commented Mar 4, 2026

quick fix for the dashcore dependency in rs-platform-encryption

Summary by CodeRabbit

  • Chores
    • Updated dependency resolution for dashcore from external reference to workspace-based approach, improving build configuration management.

@github-actions github-actions bot added this to the v3.1.0 milestone Mar 4, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: df2d1f64-f6f3-43ac-85b7-9027567c6338

📥 Commits

Reviewing files that changed from the base of the PR and between 44dbf4d and 3c3e01b.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • packages/rs-platform-encryption/Cargo.toml

📝 Walkthrough

Walkthrough

Updated the dashcore dependency specification in rs-platform-encryption's Cargo.toml from a git-based revision reference to a workspace-based dependency, changing how the package resolves its dashcore import without altering other dependencies or code logic.

Changes

Cohort / File(s) Summary
Dependency Resolution Update
packages/rs-platform-encryption/Cargo.toml
Changed dashcore dependency from git-based rev reference to workspace-based dependency (workspace = true).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A hop toward unity,
From git refs to workspace we flee,
One line adjusted, dependencies aligned,
Simpler resolution, peace of mind!
🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the dashcore dependency in rs-platform-encryption to use a workspace-based dependency instead of a git reference.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/fix-encryption-dep

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

✅ DashSDKFFI.xcframework built for this PR.

SwiftPM (host the zip at a stable URL, then use):

.binaryTarget(
  name: "DashSDKFFI",
  url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
  checksum: "1693e65caa715a5cfc55140175686e1c8ecd4bdce7b0972a6a85d481dcf85da3"
)

Xcode manual integration:

  • Download 'DashSDKFFI.xcframework' artifact from the run link above.
  • Drag it into your app target (Frameworks, Libraries & Embedded Content) and set Embed & Sign.
  • If using the Swift wrapper package, point its binaryTarget to the xcframework location or add the package and place the xcframework at the expected path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant