build: update rust-dashcore to latest v0.42-dev 9959201

[lklimek]

Issue being fixed or feature implemented

Keep rust-dashcore dependency up to date with the latest v0.42-dev branch.

What was done?

• Updated all workspace rust-dashcore dependencies (dashcore, dash-spv, dash-spv-ffi, key-wallet, key-wallet-manager, dashcore-rpc) from 0bc6592 → 9959201
• Unified rs-platform-encryption which was pinned to a separate older rev (2bd764f) — now all crates point to the same commit
• Regenerated Cargo.lock

How Has This Been Tested?

• cargo check --workspace passes (excluding pre-existing wasm-dpp2 errors unrelated to this change)
• https://github.com/dashpay/platform/actions/runs/22954554020

Breaking Changes

None expected — this is a dependency bump within the same v0.42 line.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed

_{🤖 Co-authored by Claudius the Magnificent AI Agent}

Summary by CodeRabbit

• Chores

  • Updated workspace dependencies to a newer revision for improved stability and compatibility.
  • Fixed dependency naming and moved one encryption component to use the workspace dependency.

• Breaking Changes

  • Removed a transaction-creation method from the platform wallet interface; dependent integrations will need updates.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 142dd931-b55c-406b-9f0a-2e2de7a5832f

📥 Commits

Reviewing files that changed from the base of the PR and between 1d8ed1c and 05a9d62.

📒 Files selected for processing (1)

• packages/rs-platform-encryption/Cargo.toml

---

📝 Walkthrough

Walkthrough

Updated workspace dependency revisions for dashcore-related crates and fixed invalid dependency keys by removing leading hyphens. Switched a package dashcore entry to workspace usage. Removed the create_unsigned_payment_transaction method and its related imports from the WalletInfoInterface implementation.

Changes

Cohort / File(s)	Summary
Workspace & root manifest Cargo.toml	Updated [workspace.dependencies] entries: bumped git rev for dashcore, dash-spv, dash-spv-ffi, dashcore-rpc, key-wallet, and key-wallet-manager; fixed invalid keys by removing leading hyphens.
Package manifest packages/rs-platform-encryption/Cargo.toml	Replaced explicit dashcore git rev entry with dashcore = { workspace = true }.
WalletInfoInterface implementation packages/rs-platform-wallet/src/platform_wallet_info/wallet_info_interface.rs	Removed create_unsigned_payment_transaction method and dropped imports: FeeLevel, AccountTypePreference, TransactionError, and Address (dashcore).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A nibble here, a tidy tweak,
New revisions hop, the old we seek,
Hyphens gone, the names stand free,
One small method hops away from me—
Fresh crates, light paws, a cleaner tree. 🌿

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately captures the main objective: updating rust-dashcore dependencies to a specific commit (9959201) on the v0.42-dev line, which aligns with the primary changes across Cargo.toml files and the code adaptation to upstream API changes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/update-rust-dashcore-dep

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

✅ DashSDKFFI.xcframework built for this PR.

• Workflow run: https://github.com/dashpay/platform/actions/runs/22964368260
• Artifacts: DashSDKFFI.xcframework (folder), DashSDKFFI.xcframework.zip, xc_checksum.txt

SwiftPM (host the zip at a stable URL, then use):

.binaryTarget(
  name: "DashSDKFFI",
  url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
  checksum: "4a236766b7888b843c0be943b0d2e8238c177b061810011ba970daafa9ed23e6"
)

Xcode manual integration:

• Download 'DashSDKFFI.xcframework' artifact from the run link above.
• Drag it into your app target (Frameworks, Libraries & Embedded Content) and set Embed & Sign.
• If using the Swift wrapper package, point its binaryTarget to the xcframework location or add the package and place the xcframework at the expected path.

[Copilot]

Pull request overview

Updates the workspace’s rust-dashcore-sourced dependencies to the latest v0.42-dev commit and aligns downstream code/lockfile to the new API surface.

Changes:

• Bumped dashcore / dash-spv / key-wallet / dashcore-rpc workspace git revs to 9959201….
• Updated platform-encryption’s pinned dashcore rev to the same commit.
• Adjusted PlatformWalletInfo’s WalletInfoInterface impl to match upstream trait changes and regenerated Cargo.lock.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File	Description
packages/rs-platform-wallet/src/platform_wallet_info/wallet_info_interface.rs	Removes now-obsolete delegated method and cleans imports to match updated upstream traits/types.
packages/rs-platform-encryption/Cargo.toml	Aligns dashcore git rev with the workspace-wide rust-dashcore commit.
Cargo.toml	Updates workspace dependency git rev pins for rust-dashcore family crates.
Cargo.lock	Regenerated lockfile reflecting the new rust-dashcore commit and transitive dependency changes.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

🧹 Nitpick comments (1)

packages/rs-platform-encryption/Cargo.toml (1)

11-11: Use workspace = true to inherit dashcore from the root Cargo.toml.

This crate duplicates the workspace dependency definition from line 50 of the root Cargo.toml without any crate-specific overrides. Using workspace = true keeps the dependency revision single-sourced and prevents drift on future updates.

-dashcore = { git = "https://github.com/dashpay/rust-dashcore", rev = "9959201593826def0ad1f6db51b2ceb95b68a1ca" }
+dashcore = { workspace = true }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/rs-platform-encryption/Cargo.toml` at line 11, The dashcore
dependency in this crate duplicates the root workspace revision; replace the
current git+rev entry for dashcore with a workspace reference so it inherits the
root definition (i.e., change the dashcore dependency in this crate's Cargo.toml
to use workspace = true instead of specifying git and rev), ensuring the crate
no longer pins its own git/rev and will follow the root Cargo.toml's dashcore
revision.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@packages/rs-platform-encryption/Cargo.toml`:
- Line 11: The dashcore dependency in this crate duplicates the root workspace
revision; replace the current git+rev entry for dashcore with a workspace
reference so it inherits the root definition (i.e., change the dashcore
dependency in this crate's Cargo.toml to use workspace = true instead of
specifying git and rev), ensuring the crate no longer pins its own git/rev and
will follow the root Cargo.toml's dashcore revision.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8ba3fbbf-624b-47b6-a7b9-b92ba68cec9d

📥 Commits

Reviewing files that changed from the base of the PR and between 512db4b and 1d8ed1c.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (3)

• Cargo.toml
• packages/rs-platform-encryption/Cargo.toml
• packages/rs-platform-wallet/src/platform_wallet_info/wallet_info_interface.rs