Open
Conversation
Issue data-8#618 states that the return values for the type of rows and columns result in different things. I believe this should keep it uniform between them.
Member
|
While this is clever, these are the two things I'd like to see before I'm willing to approve:
|
adnanhemani
requested changes
May 24, 2025
Member
adnanhemani
left a comment
adnanhemani
left a comment
There was a problem hiding this comment.
Please push the tests to re-run the CI/CD here. Seems like the AI in #639 did the same thing and the CI/CD worked there, so I think this will work here as well.
davidwagner
reviewed
May 27, 2025
| else: | ||
| index = self._table.column_index(index_or_label) | ||
| return self[index] | ||
| value = self[index] |
Member
There was a problem hiding this comment.
Our automated tests complain that this line mixes tabs and spaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #618 states that the return values for the type of rows and columns result in different things. I believe this should keep it uniform between them.
(First time contributor)
Changes proposed:
Updated the Row.item() function to align better with the column output.
Completed to solve Issue #618