Conversation
parkan
force-pushed
the
remove-mysql-support
branch
2 times, most recently
from
c5caa91 to
4f2766e
Compare
only sqlite and postgres are supported going forward. operators on mysql should migrate to postgres before upgrading -- the binary now refuses to start with a mysql connection string. removes: - mysql driver (gorm.io/driver/mysql, go-sql-driver/mysql) - mysql-specific dialect branches in migrate.go, healthcheck, export-keys - mysql deadlock debugging helpers (database/deadlock_debug.go, testutil/deadlock.go) - mysql-only cascade cycle test - mariadb from devcontainer (Dockerfile, init/start scripts, env vars) - mysql setup from CI action - mysql from SupportedTestDialects
parkan
force-pushed
the
remove-mysql-support
branch
from
4f2766e to
54a59c3
Compare
Collaborator
Author
|
sorry about the failure noise, github runners are always lots of fun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maintaining around mysql quirks has been an absolute nightmare and is of unclear value; some of the new features (e.g. shovel) are natively postgres-only
propose removing mysql support to reduce maintainer load
removes: