chore(logger): upgrade logforth to support global max_files limit for log_dir#17637
chore(logger): upgrade logforth to support global max_files limit for log_dir#17637bohutang merged 3 commits intodatabendlabs:mainfrom
Conversation
|
This is a temporary solution, right? I see logforth 0.23 has already supported the max file limit: https://github.com/fast/logforth/blob/d9620447ba9be53a730d8960f103445de79076a9/src/append/rolling_file/rolling.rs#L137-L142 |
No, this is the final solution. |
|
The log section with: Test use "It feels like the number of generated log files is far beyond what was expected." |
|
cc @wubx From my local test, this works as expected. I only tested as: Case 2: |
|
From the latest code I don't see the date time being used as part of filename (prefix), then we may not need this workaround now? See fast/logforth#207. |

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Upgrade logforth with Global File Limit Capability
Upgrades to logforth from https://github.com/datafuse-extras/logforth (global-max-files-v0.14 branch), which adds the ability to limit the total number of log files in
log_dirvia PR #1.Tests
Type of change
This change is