Skip to content

Added WRED with affected Leaf/LC/FM model check#379

Open
Priyanka-Patil14 wants to merge 6 commits intodatacenter:v4.1.0-devfrom
Priyanka-Patil14:bugfix/CSCwt50713
Open

Added WRED with affected Leaf/LC/FM model check#379
Priyanka-Patil14 wants to merge 6 commits intodatacenter:v4.1.0-devfrom
Priyanka-Patil14:bugfix/CSCwt50713

Conversation

@Priyanka-Patil14
Copy link
Copy Markdown

Summary

Adds a new pre-upgrade validation check to detect fabric nodes at risk due to CSCwt50713, where WRED-enabled QoS combined with specific Leaf/LC/FM hardware models can cause N9504 spine crashes after upgrading to affected ACI releases.

Detection Logic

Three gates must all be true to trigger a FAIL:

  1. Version Gate – Target version is in the affected range:

    • ACI 6.1(x) older than 6.1(6a)
    • ACI 6.2(x) older than 6.2(2a)
  2. Feature Gate – WRED is enabled (qosCong.algo = wred)

  3. Hardware Gate – Any of the following affected models are present:

    • Leaf: N9K-C9236C, N9K-C92300YC, N9K-C9272Q, N9K-C92304QC
    • LC: N9K-C92304QC
    • FM: N9K-C9504-FM-E, N9K-C9508-FM-E, N9K-C9516-FM-E

Testing

  • 5 unit test cases added under tests/checks/wred_affected_model_check/
  • All 5 passed
  • Validated on live fabric (fab3-apic1): confirmed FAIL_O with real hit on node 201 (FAB3-S1, N9K-C9504-FM-E)

@Priyanka-Patil14
Copy link
Copy Markdown
Author

WredCheck_APIC_Output_logs.txt
WredCheck_Pytest_Logs.txt

Uploaded the test logs.

Copy link
Copy Markdown

@Harinadh-Saladi Harinadh-Saladi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls address the comments given and also Pls add the bug details in validations.md file. It's missing.
Pls execute the script on Fab3 and share PASS, FAIL and NA logs. Will review it.

Comment thread tests/checks/wred_affected_model_check/test_wred_affected_model_check.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
@Priyanka-Patil14
Copy link
Copy Markdown
Author

Pls address the comments given and also Pls add the bug details in validations.md file. It's missing. Pls execute the script on Fab3 and share PASS, FAIL and NA logs. Will review it.

WRED_PASS:FAIL:NA_APIC_Logs.txt

Please find the attached logs. Executed on fab3 for PASS, FAIL and NA scenario.

Comment thread docs/docs/validations.md Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Copy link
Copy Markdown

@lovkeshsharma702 lovkeshsharma702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please work on all comments.

Comment thread docs/docs/validations.md Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread aci-preupgrade-validation-script.py
Copy link
Copy Markdown

@lovkeshsharma702 lovkeshsharma702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

work on comments

Comment thread aci-preupgrade-validation-script.py Outdated
Copy link
Copy Markdown

@Harinadh-Saladi Harinadh-Saladi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls address the comments. If there is any different understanding with me in the test results or technical aspects, will discuss with team and address after getting the confirmation.

Comment thread docs/docs/validations.md Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread tests/checks/wred_affected_model_check/test_wred_affected_model_check.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread tests/checks/wred_affected_model_check/eqptLC_affected.json Outdated
Comment thread tests/checks/wred_affected_model_check/test_wred_affected_model_check.py Outdated
Comment thread tests/checks/wred_affected_model_check/test_wred_affected_model_check.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread tests/checks/wred_affected_model_check/eqptFC_mixed.json
Copy link
Copy Markdown

@lovkeshsharma702 lovkeshsharma702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please sort the other comments and we are good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants