test: add MaintenanceRequestsController integration tests (Story 21.1)#372
Merged
daveharmswebdev merged 1 commit intomainfrom Apr 19, 2026
Conversation
Backfill 27 WebApplicationFactory integration tests covering all 4 endpoints of MaintenanceRequestsController. Extends the test factory with additive helpers (CreateTenantUserInAccountAsync, CreatePropertyInAccountAsync) without changing existing signatures. ACs were reconciled against shipped controller behavior — deltas from the original epic are documented in story Dev Notes. No production code changed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MaintenanceRequestsController(Epic 21, Story 21.1 — closes test-coverage gap identified in issue Testing pyramid gaps: integration + E2E coverage for newer features #371)PropertyManagerWebApplicationFactoryadditively withCreateTenantUserInAccountAsyncandCreatePropertyInAccountAsync— existing helpers unchanged (verified against 558 pre-existing Api.Tests)Coverage
Test plan
dotnet test— 1845/1845 passing (558 Api + 1189 Application + 98 Infrastructure)npm test— 2751/2751 frontend unit tests passingnpx playwright test— 212/213 (1 pre-existing Reports-flow flake, unrelated)🤖 Generated with Claude Code