Skip to content

test: add MaintenanceRequestPhotosController integration tests (Story 21.2)#373

Open
daveharmswebdev wants to merge 1 commit intomainfrom
story/21-2-maintenance-request-photos-controller-integration-tests
Open

test: add MaintenanceRequestPhotosController integration tests (Story 21.2)#373
daveharmswebdev wants to merge 1 commit intomainfrom
story/21-2-maintenance-request-photos-controller-integration-tests

Conversation

@daveharmswebdev
Copy link
Copy Markdown
Owner

Summary

  • Adds 47 WebApplicationFactory integration tests for all 4 MaintenanceRequestPhotosController endpoints (upload-url, confirm, list, delete)
  • Covers auth (401), validation (400), access control (404 cross-account + cross-tenant), and happy-path flows (201/200/204)
  • Closes the P1 test coverage gap flagged in issue Testing pyramid gaps: integration + E2E coverage for newer features #371 for the tenant portal photo-upload surface, before Epic 20 work resumes
  • Zero production code changes — test-only story

Test plan

  • Backend suite: 1892/1892 passing (1189 Application + 98 Infrastructure + 605 Api)
  • Frontend suite: 2751/2751 passing
  • E2E: 212/213 (1 pre-existing flake unrelated to this story)
  • New test file alone: 47/47 passing in ~4s
  • Builds clean (backend dotnet build, frontend ng build)
  • AC-to-test mapping verified — all 19 ACs map to named [Fact] methods with meaningful assertions

Evaluate verdict: PASS on all 4 grading dimensions.

Story file: docs/project/stories/epic-21/21-2-maintenance-request-photos-controller-integration-tests.md

🤖 Generated with Claude Code

… 21.2)

Add 47 WebApplicationFactory integration tests covering all 4
MaintenanceRequestPhotosController endpoints (upload-url, confirm,
list, delete) across auth, validation, access control, and
happy-path flows. Closes the P1 test coverage gap flagged in
issue #371 before Epic 20 tenant portal work resumes.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant