add winverify to the scintilla/lexilla x86/x64 libraries#180
Open
desjarlais wants to merge 1 commit intomasterfrom
Open
add winverify to the scintilla/lexilla x86/x64 libraries#180desjarlais wants to merge 1 commit intomasterfrom
desjarlais wants to merge 1 commit intomasterfrom
Conversation
Collaborator
|
Looks nice! (Will do a through review later.) |
ahmetsait
reviewed
Apr 22, 2026
Comment on lines
+65
to
+68
| IntPtr fileInfoPtr = Marshal.AllocHGlobal(Marshal.SizeOf<WINTRUST_FILE_INFO>()); | ||
| try | ||
| { | ||
| Marshal.StructureToPtr(fileInfo, fileInfoPtr, false); |
Collaborator
There was a problem hiding this comment.
Is there anything stopping us from simply passing a pointer to the stack variables?
Owner
Author
There was a problem hiding this comment.
I think we need to marshal
https://learn.microsoft.com/en-us/windows/win32/api/wintrust/ns-wintrust-wintrust_file_info
...it converts the managed string into an unmanaged Unicode string pointer in the allocated block. A raw pointer to the stack struct would give the native code a pointer to a managed object reference, not a valid PCWSTR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native DLL loaded without integrity verification, scintilla and lexilla are signed, but arm is not so I might need to figure something out there.