Deprecate: deprecate setValue and remove deprecated Python2 objects#167
Open
cadenmyers13 wants to merge 3 commits intodiffpy:v3.3.0from
Open
Deprecate: deprecate setValue and remove deprecated Python2 objects#167cadenmyers13 wants to merge 3 commits intodiffpy:v3.3.0from
setValue and remove deprecated Python2 objects#167cadenmyers13 wants to merge 3 commits intodiffpy:v3.3.0from
Conversation
Contributor
Author
|
@sbillinge ready for review |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3.3.0 #167 +/- ##
=======================================
Coverage 72.81% 72.81%
=======================================
Files 25 25
Lines 3896 3896
=======================================
Hits 2837 2837
Misses 1059 1059
🚀 New features to boost your workflow:
|
Contributor
Author
|
Ah, codecov failed.. one sec |
Contributor
Author
|
Since there were a lot of calls to |
Contributor
Don't we have tests for set_value though? Please check, because if we do, then these lines should have coverage, no? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecation of
Parameter.setValueThere are a lot of methods in srfit called
def setValue, but i only deprecated the one insideParameterbecause that seems to be the only user-facing one. If a user wants to create a new parameter it is done through this object. The other uses ofdef setValueI just replaced withdef set_valueand did not mark with the deprecator.Also, in
src/diffpy/srfit/equation/literals/abcs.pyI removed the use ofsixand other python 2 objects. I did this with the help of chatGPT