Skip to content

nn_radius improvements; setup with conda transparently#29

Open
robbmcleod wants to merge 6 commits intodjsutherland:masterfrom
robbmcleod:master
Open

nn_radius improvements; setup with conda transparently#29
robbmcleod wants to merge 6 commits intodjsutherland:masterfrom
robbmcleod:master

Conversation

@robbmcleod
Copy link
Copy Markdown

Hi,

Two suggested changes:

  1. Some additional checks for nn_radius to allow [1,2]-shaped queries, which to me are the natural shape for such queries, and also ensures that params['checks'] is high enough to accomodate max_nn.
  2. In setup.py, try to infer if Conda is in use and set the appropriate environment variables in that case. Otherwise it doesn't work out-of-the-box.

I can squash or separate the PRs if you want, I was a bit lazy in committing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant