nn_radius improvements; setup with conda transparently#29
Open
robbmcleod wants to merge 6 commits intodjsutherland:masterfrom
Open
nn_radius improvements; setup with conda transparently#29robbmcleod wants to merge 6 commits intodjsutherland:masterfrom
nn_radius improvements; setup with conda transparently#29robbmcleod wants to merge 6 commits intodjsutherland:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Two suggested changes:
nn_radiusto allow [1,2]-shaped queries, which to me are the natural shape for such queries, and also ensures thatparams['checks']is high enough to accomodatemax_nn.setup.py, try to infer if Conda is in use and set the appropriate environment variables in that case. Otherwise it doesn't work out-of-the-box.I can squash or separate the PRs if you want, I was a bit lazy in committing.