fix: only refresh election timer when vote is granted#281
Merged
sakno merged 1 commit intodotnet:developfrom Mar 27, 2026
Merged
fix: only refresh election timer when vote is granted#281sakno merged 1 commit intodotnet:developfrom
sakno merged 1 commit intodotnet:developfrom
Conversation
Collaborator
|
Many thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi again! I noticed a small performance improvement opportunity in VoteAsync while reading the code.
Currently in RaftCluster.cs, the election timer is refreshed (line 827) before checking whether the vote is actually granted (line 834). This means a rejected RequestVote still resets the follower's election timer, which can delay elections unnecessarily in split-vote scenarios — the follower keeps getting its timer refreshed by candidates it doesn't vote for.
The Raft paper only resets the election timer when a vote is actually granted. This change moves the Refresh() call to after the vote decision, so only granted votes refresh the timer.