[release/6.5] Fix HierarchyId parsing for numbers outside Int32 range#2362
Open
Copilot wants to merge 2 commits intorelease/6.5from
Open
[release/6.5] Fix HierarchyId parsing for numbers outside Int32 range#2362Copilot wants to merge 2 commits intorelease/6.5from
Copilot wants to merge 2 commits intorelease/6.5from
Conversation
Copilot
AI
changed the title
[WIP] Port changes from EF6 pull request 2359
Fix HierarchyId parsing for numbers outside Int32 range
Mar 5, 2026
roji
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of dotnet/ef6#2359
HierarchyIdfails to parse valid IDs containing numbers outside the Int32 range (e.g. SQL Server file tablepath_locatordefaults), throwingArgumentExceptiondue toint.TryParseoverflow.Changes
HierarchyId.cs: Change_nodesfromint[][]tolong[][]; switch parsing tolong.TryParse; fixnew[] { 1 }→new[] { 1L }inGetDescendantIntArrayToStirng→LongArrayToString(IEnumerable<long>);CompareIntArrays→CompareLongArrays(long[],longlocals); update all call sitesHierarchyIdUnitTests.cs: Add tests for parsing IDs with out-of-Int32-range numbers and for comparison operators on large valuesWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
4myvsblobprodcus32.vsblob.vsassets.io/usr/bin/dotnet dotnet build src/EntityFramework/EntityFramework.csproj -c Debug(dns block)vb4vsblobprodcus33.vsblob.vsassets.io/usr/bin/dotnet dotnet build src/EntityFramework/EntityFramework.csproj -c Debug(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.