Skip to content

Upgrade the core package to avoid the set-output deprecation#19

Merged
AnEcobeeTon merged 3 commits intomasterfrom
remove-deprecations
Mar 19, 2026
Merged

Upgrade the core package to avoid the set-output deprecation#19
AnEcobeeTon merged 3 commits intomasterfrom
remove-deprecations

Conversation

@AnEcobeeTon
Copy link
Copy Markdown
Contributor

Whenever the create-release GHA is run, we get a bunch of these warnings:

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Screenshot 2026-03-17 at 11 22 55 AM

So let's upgrade the core package so that we are not caught by surprise one day.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an important maintenance task by upgrading core GitHub Actions dependencies and other development tools. The primary goal is to eliminate set-output deprecation warnings that appear during the create-release workflow, ensuring the action remains functional and compliant with future GitHub Actions platform changes. The update also brings several development dependencies to more recent versions, improving overall project health and leveraging newer features.

Highlights

  • Dependency Upgrades: Multiple development dependencies, including @actions/core, @actions/github, Jest, and TypeScript, were upgraded to their latest major versions to address deprecation warnings and improve compatibility.
  • GitHub API Client Update: The GitHub API calls in src/main.ts were updated to use the new octokit.rest namespace, aligning with changes in the @actions/github library.
  • Jest Configuration Simplification: The explicit testRunner configuration for jest-circus was removed from jest.config.js, as it is likely now the default or no longer required.
Changelog
  • jest.config.js
    • Removed explicit testRunner configuration for jest-circus.
  • package.json
    • Upgraded @actions/core from 1.1.1 to ^1.10.1.
    • Upgraded @actions/github from 4.0.0 to ^5.1.1.
    • Upgraded @types/jest from 24.0.18 to ^29.5.0.
    • Upgraded @types/node from 12.7.5 to ^16.18.0.
    • Upgraded jest from 24.9.0 to ^29.5.0.
    • Upgraded jest-circus from ^24.7.1 to ^29.5.0.
    • Upgraded ts-jest from ^24.2.0 to ^29.1.0.
    • Upgraded typescript from ^3.6.3 to ^4.9.5.
  • src/main.ts
    • Updated octokit.repos.listReleases to octokit.rest.repos.listReleases.
    • Updated octokit.repos.compareCommits to octokit.rest.repos.compareCommits.
    • Updated octokit.repos.createRelease to octokit.rest.repos.createRelease.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses the set-output deprecation warning by upgrading @actions/core and other related dependencies. The API calls to octokit have been updated correctly for the new version of @actions/github.

However, I've identified a critical issue: while the Node.js types have been updated to v16, the action's runtime in action.yml is still set to node12. Node.js 12 is no longer supported on GitHub runners, and this mismatch will cause the action to fail. I've left a comment with details on how to resolve this.


core.info(`Listing releases for ${owner}/${repo}`)
const {data: releases} = await octokit.repos.listReleases({
const {data: releases} = await octokit.rest.repos.listReleases({
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious what the motivation for adding rest was

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new version of the octokit library changed their api a bit, so we now have to pick rest or graphql.

@AnEcobeeTon AnEcobeeTon merged commit 9e7fb58 into master Mar 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants