Upgrade the core package to avoid the set-output deprecation#19
Upgrade the core package to avoid the set-output deprecation#19AnEcobeeTon merged 3 commits intomasterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an important maintenance task by upgrading core GitHub Actions dependencies and other development tools. The primary goal is to eliminate Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly addresses the set-output deprecation warning by upgrading @actions/core and other related dependencies. The API calls to octokit have been updated correctly for the new version of @actions/github.
However, I've identified a critical issue: while the Node.js types have been updated to v16, the action's runtime in action.yml is still set to node12. Node.js 12 is no longer supported on GitHub runners, and this mismatch will cause the action to fail. I've left a comment with details on how to resolve this.
|
|
||
| core.info(`Listing releases for ${owner}/${repo}`) | ||
| const {data: releases} = await octokit.repos.listReleases({ | ||
| const {data: releases} = await octokit.rest.repos.listReleases({ |
There was a problem hiding this comment.
curious what the motivation for adding rest was
There was a problem hiding this comment.
The new version of the octokit library changed their api a bit, so we now have to pick rest or graphql.
Whenever the
create-releaseGHA is run, we get a bunch of these warnings:So let's upgrade the core package so that we are not caught by surprise one day.