Remove .go-version and source Go version from go.mod#20796
Draft
Remove .go-version and source Go version from go.mod#20796
Conversation
Use go.mod as the single source of truth for Go version selection by replacing all remaining .go-version references in Tilt, CI validation, and updatecli automation. Made-with: Cursor
Contributor
🤖 GitHub commentsJust comment with:
|
kruskall
reviewed
Mar 31, 2026
| uses: tj-actions/changed-files@22103cc46bda19c2b464ffe86db46df6922fd323 # v47.0.5 | ||
| with: | ||
| files: .go-version | ||
| files: go.mod |
Member
There was a problem hiding this comment.
this is gonna run quite often :(
2 tasks
Contributor
|
This pull request does not have a backport label. Could you fix it @carsonip? 🙏
|
Collaborator
💚 Build Succeeded
|
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Use
go.modas the single source of truth for Go versioning by removing.go-versionand replacing all remaining references that depended on it.This removes version drift risk between files and keeps packaging, CI checks, and local Tilt behavior aligned with the build configuration already used by
actions/setup-goand Make targets.Checklist
For functional changes, consider:
How to test these changes
.go-versionreferences remain:rg "\\.go-version"go.mod:rg "grep '\^go ' go.mod|go-version-file: go.mod|go-version-file: systemtest/go.mod|go-version-file: integrationservertest/go.mod"make package-snapshotRelated issues
None.
Made with Cursor