Skip to content

Remove .go-version and source Go version from go.mod#20796

Draft
carsonip wants to merge 1 commit intomainfrom
chore/remove-go-version-file-refs
Draft

Remove .go-version and source Go version from go.mod#20796
carsonip wants to merge 1 commit intomainfrom
chore/remove-go-version-file-refs

Conversation

@carsonip
Copy link
Copy Markdown
Member

Motivation/summary

Use go.mod as the single source of truth for Go versioning by removing .go-version and replacing all remaining references that depended on it.

This removes version drift risk between files and keeps packaging, CI checks, and local Tilt behavior aligned with the build configuration already used by actions/setup-go and Make targets.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

  • Verify no .go-version references remain:
    • rg "\\.go-version"
  • Verify Go version resolution now comes from go.mod:
    • rg "grep '\^go ' go.mod|go-version-file: go.mod|go-version-file: systemtest/go.mod|go-version-file: integrationservertest/go.mod"
  • Optionally run:
    • make package-snapshot

Related issues

None.

Made with Cursor

Use go.mod as the single source of truth for Go version selection by replacing all remaining .go-version references in Tilt, CI validation, and updatecli automation.

Made-with: Cursor
@carsonip carsonip requested review from a team as code owners March 31, 2026 16:34
@github-actions
Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@carsonip carsonip added backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches backport-active-8 Automated backport with mergify to all the active 8.[0-9]+ branches labels Mar 31, 2026
Comment thread .github/workflows/ci.yml
uses: tj-actions/changed-files@22103cc46bda19c2b464ffe86db46df6922fd323 # v47.0.5
with:
files: .go-version
files: go.mod
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is gonna run quite often :(

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's true 😞

@carsonip carsonip mentioned this pull request Mar 31, 2026
2 tasks
@carsonip carsonip marked this pull request as draft March 31, 2026 16:39
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 31, 2026

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8.19 is the label to automatically backport to the 8.19 branch.
  • backport-9./d is the label to automatically backport to the 9./d branch. /d is the digit.
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@elasticmachine
Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

@v1v
Copy link
Copy Markdown
Member

v1v commented Apr 1, 2026

Tiltfile also uses it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-8 Automated backport with mergify to all the active 8.[0-9]+ branches backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants