Skip to content

Comments

ti_threatconnect: update pipeline to lowercase all hashes#17455

Open
GShepherdTC wants to merge 7 commits intoelastic:mainfrom
GShepherdTC:main
Open

ti_threatconnect: update pipeline to lowercase all hashes#17455
GShepherdTC wants to merge 7 commits intoelastic:mainfrom
GShepherdTC:main

Conversation

@GShepherdTC
Copy link
Contributor

@GShepherdTC GShepherdTC commented Feb 18, 2026

Proposed commit message

Updated pipeline to lowercase all hashes

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • Check code changes. Should be pretty straight forward.

How to test this PR locally

Run the pipeline test. I updated the response data to match.

Related issues

Screenshots

No changes to UI.

@elastic-vault-github-plugin-prod

Reviewers

Buildkite won't run for external contributors automatically; you need to add a comment:

  • /test : will kick off a build in Buildkite.

NOTE: https://github.com/elastic/integrations/blob/main/.buildkite/pull-requests.json contains all those details.

@GShepherdTC GShepherdTC marked this pull request as ready for review February 18, 2026 21:38
@GShepherdTC GShepherdTC requested a review from a team as a code owner February 18, 2026 21:38
@efd6 efd6 changed the title Breaking change: Updated pipeline to lowercase all hashes ti_threatconnect: update pipeline to lowercase all hashes Feb 18, 2026
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested commit message:

ti_threatconnect: lowercase all hash values in indicator processing

Hash values should be normalized to lowercase for consistent matching
and deduplication across threat intelligence sources.

though this probably needs expansion. I think we want to know what visualisation and saved search impacts this will have.

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened a ECS issue to advise using lowercase for the hashes.

While reviewing I noticed that ECS threat.indicator.file.size and threat.indicator.geo.location were present in the TC data but completely missing from the ECS mapping. Can you please map those as well to improve ECS coverage?

@andrewkroh andrewkroh added Integration:ti_threatconnect ThreatConnect (Partner supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Feb 18, 2026
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

GShepherdTC and others added 5 commits February 19, 2026 13:43
ti_threatconnect: lowercase all hash values in indicator processing

Hash values should be normalized to lowercase for consistent matching
and deduplication across threat intelligence sources.

Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Integration:ti_threatconnect ThreatConnect (Partner supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants