fix: convert file path via vm.toVmFile() in windowsSignAzureManager#9676
Draft
fix: convert file path via vm.toVmFile() in windowsSignAzureManager#9676
Conversation
🦋 Changeset detectedLatest commit: 9fb50a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Agent-Logs-Url: https://github.com/electron-userland/electron-builder/sessions/f4060456-190f-4301-afbb-99bffdd0bc5b Co-authored-by: mmaietta <5238867+mmaietta@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix improper file path in windowsSignAzureManager on MacOS
fix: convert file path via vm.toVmFile() in windowsSignAzureManager
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS with Parallels,
windowsSignAzureManagerwas passing the raw Mac file path toInvoke-TrustedSigninginstead of the translated VM path, causing the command to fail.Changes
windowsSignAzureManager.ts: Applyvm.toVmFile()tooptions.pathbefore passing it as theFilesparameter, consistent with howwindowsSignToolManager.tsalready handles this.This converts Mac-style paths (e.g.
/Volumes/CaseSensitive/project/...) to their Windows VM equivalents (e.g.\\Mac\Host\Volumes\CaseSensitive\project\...) before invoking the signing command.