Correctly extract passwords with colons from URL#4709
Merged
josevalim merged 1 commit intoelixir-ecto:masterfrom Mar 12, 2026
Merged
Correctly extract passwords with colons from URL#4709josevalim merged 1 commit intoelixir-ecto:masterfrom
josevalim merged 1 commit intoelixir-ecto:masterfrom
Conversation
Member
Yes, we are still formatting the codebase bit by bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It correctly works if the password is URL encoded, but since passwords with colon are very common it is better to support them directly as well.
Surprisingly I noticed that
mix formatdoes not work in the repo and there is no CI check for formatted code. The reason is that.formatter.exsis missing:inputs. Is this intentional?