fix(DataTable): add null check for data in Column component#3265
Open
adchamberlain wants to merge 1 commit intoevidence-dev:mainfrom
Open
fix(DataTable): add null check for data in Column component#3265adchamberlain wants to merge 1 commit intoevidence-dev:mainfrom
adchamberlain wants to merge 1 commit intoevidence-dev:mainfrom
Conversation
The checkColumnName() function in Column.svelte was accessing $props.data[0] without first checking if data was available. This caused DataTable to silently fail when data was loaded asynchronously (e.g., via Query objects), resulting in the table container rendering but no rows being displayed. Added guard clause to return early if data is not yet ready, allowing the reactive update to properly register columns once data becomes available. Fixes issue where DataTable shows search/pagination but no rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Added null check in Column.svelte's
checkColumnName()function to guard against data not beingready during initial render.
Changes