Skip to content

fix clang build with glibc 2.42 re: struct termio#1938

Open
etwoo wants to merge 1 commit intofacebook:mainfrom
etwoo:bugfix/backport-llvm-struct-termio-glibc-2.42
Open

fix clang build with glibc 2.42 re: struct termio#1938
etwoo wants to merge 1 commit intofacebook:mainfrom
etwoo:bugfix/backport-llvm-struct-termio-glibc-2.42

Conversation

@etwoo
Copy link
Contributor

@etwoo etwoo commented Aug 23, 2025

I hit some issues building Infer from source in my Arch Linux dev environment. The problem seems to be specific to compiling against glibc 2.42, which Arch recently accepted into its official repositories.

The fix in this PR is to backport fixes from LLVM upstream for llvm/llvm-project#137321

@meta-cla meta-cla bot added the CLA Signed label Aug 23, 2025
@etwoo etwoo force-pushed the bugfix/backport-llvm-struct-termio-glibc-2.42 branch from 2a0ddb8 to 0e4d6ce Compare September 18, 2025 06:48
@etwoo
Copy link
Contributor Author

etwoo commented Sep 18, 2025

Assuming the feedback from #1939 (comment) would also apply here, I've rebased this bugfix branch onto HEAD of main.

@grooverdan
Copy link

thanks for the patch, worked for me on Fedora 43

Upstream LLVM recently gained support for building with glibc 2.42:

    llvm/llvm-project@59978b2
    llvm/llvm-project@c99b1bc

Backport these fixes to this project's vendored copy of clang. This
allows us to build Infer on Arch Linux, which recently upgraded its
glibc to 2.42:

    https://gitlab.archlinux.org/archlinux/packaging/packages/glibc/-/commit/3543edc0a9e583f9c3880c197d83409c5e8d4020
@etwoo etwoo force-pushed the bugfix/backport-llvm-struct-termio-glibc-2.42 branch from 0e4d6ce to 11a1c92 Compare March 3, 2026 04:37
@etwoo
Copy link
Contributor Author

etwoo commented Mar 3, 2026

This repo's CI workflow appears to have changed since the last discussion on this PR 5-6 months ago. Accordingly, I've rebased this bugfix branch onto HEAD of main to get an up-to-date, successful CI run:

@ngorogiannis : please let me know if you have any feedback. When I originally opened this PR, I was not sure if only people building infer from source outside of Facebook's infrastructure would benefit; if this amounts to a downstream-only patch, I would totally understand declining this PR.

@meta-codesync
Copy link
Contributor

meta-codesync bot commented Mar 4, 2026

@ngorogiannis has imported this pull request. If you are a Meta employee, you can view this in D95171884.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants