Open
Conversation
pbukva
reviewed
Apr 2, 2026
Comment on lines
+73
to
77
| if isSudoAdminFunc == nil { | ||
| k.IsSudoAdminFunc = k.DefaultIsSudoAdminFunc | ||
| } else { | ||
| k.IsSudoAdminFunc = isSudoAdminFunc | ||
| } |
Collaborator
There was a problem hiding this comment.
I would not do this. If someone intentionally passes nil as the input value of the isSudoAdminFunc parameter, then it shall very much mean, that sudoers are disabled.
Caller of this function shall not need to be aware that nil value will be replaced by default impl. of the function.This implicit behaviur can potentially lead to serious implications ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.