feat(remote-config): add optional exposurePercent field to ExperimentValue#3096
feat(remote-config): add optional exposurePercent field to ExperimentValue#3096tusharkhandelwal8 wants to merge 3 commits intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new optional field, Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds an optional exposurePercent field to the ExperimentValue interface, allowing the SDK to expose the percentage of users included in an experiment. The changes include updating the interface definition and its corresponding API documentation, as well as updating unit tests to cover the new field. The implementation is straightforward and correct. I have one suggestion to improve the documentation for the new field to ensure its correct usage.
feat(remote-config): add exposurePercent to ExperimentValue interface
Add optional
exposurePercentfield toExperimentValueto expose thepercentage of users included in an experiment. This follows up on #3046
which introduced the ExperimentValue type.