Update thinpool setup script in getting-started.md#548
Open
cauld wants to merge 3 commits intofirecracker-microvm:mainfrom
Open
Update thinpool setup script in getting-started.md#548cauld wants to merge 3 commits intofirecracker-microvm:mainfrom
cauld wants to merge 3 commits intofirecracker-microvm:mainfrom
Conversation
This script assumes the /var/lib/firecracker-containerd/snapshotter/devmapper directory exists. Adding a directory check/create if needed block.
Contributor
|
Thanks, this looks good, but we need a DCO to merge. You can use |
Signed-off-by: Chad Auld <chadauld@gmail.com> This script assumes the /var/lib/firecracker-containerd/snapshotter/devmapper directory exists. Adding a directory check/create if needed block.
Author
|
Added signed off |
Contributor
|
The original commit and the merge are missing a sign off. Can you please rebase to remove the later commits and then modify the original commit to add the sign off? |
Contributor
|
@cauld, can you squash locally and force push to your branch so that all commits are signed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
The example thinpool setup in this guide script assumes the /var/lib/firecracker-containerd/snapshotter/devmapper directory exists. If fails if not. Added a directory check/create if needed block.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.