Add container_snapshot_path to load snapshot request#508
Draft
CuriousGeorgiy wants to merge 2 commits intofirecracker-microvm:mainfrom
Draft
Add container_snapshot_path to load snapshot request#508CuriousGeorgiy wants to merge 2 commits intofirecracker-microvm:mainfrom
container_snapshot_path to load snapshot request#508CuriousGeorgiy wants to merge 2 commits intofirecracker-microvm:mainfrom
Conversation
Author
Author
|
This PR is not intended to be merged, it just serves as an illustration of what I want to achieve in firecracker-microvm/firecracker#4014. |
According to the firecracker OpenAPI specification [1], creating vsock devices is only a pre-boot request, so adding vsocks after loading a snapshot fails. It also seems redundant, since the VM loaded from a snapshot restores vsocks anyways. Closes firecracker-microvm#506 1. https://github.com/firecracker-microvm/firecracker/blob/56aeeac51c00b449a45be4542b3e807d34690ba7/src/api_server/swagger/firecracker.yaml#L676-L678 Signed-off-by: Georgiy Lebedev <lebedev.gk@phystech.edu>
Forward the `container_snapshot_path` parameter of the firecracker load snapshot request. Signed-off-by: Georgiy Lebedev <lebedev.gk@phystech.edu>
CuriousGeorgiy
force-pushed
the
vhive-integration
branch
from
abb9daa to
1afa908
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: firecracker-microvm/firecracker#4014
Description of changes:
Forward the
container_snapshot_pathparameter of the firecracker loadsnapshot request.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.