Skip to content

fix: options are sometimes not applied when switching buffers or restored when leaving zen mode. Fixes #95#99

Open
Subjective wants to merge 2 commits intofolke:mainfrom
Subjective:fix-apply-and-restore-options
Open

fix: options are sometimes not applied when switching buffers or restored when leaving zen mode. Fixes #95#99
Subjective wants to merge 2 commits intofolke:mainfrom
Subjective:fix-apply-and-restore-options

Conversation

@Subjective
Copy link
Copy Markdown

@Subjective Subjective commented Sep 3, 2023

  • fix: switching buffers doesn't apply zen mode options
  • fix: original options aren't restored for buffers not already loaded

Also ensures that the correct buffer will be set after switching buffers upon exiting Zen mode. Previously, just the original buffer Zen mode was activated in would be restored.

Closes #95

@Subjective Subjective changed the title fix: options are sometimes not applied or restored when leaving zen mode. Fixes #95 fix: options are sometimes not applied when switching buffers or restored when leaving zen mode. Fixes #95 Sep 3, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 6, 2024

This PR is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the stale This issue or PR has been inactive for a while label Jul 6, 2024
@drewvlaz
Copy link
Copy Markdown

Will this be merged at some point? Also experiencing issues of

starting zen mode -> switching buffer -> exiting zen mode -> being returned to original buffer when I expect to stay in current buffer

@github-actions github-actions bot removed the stale This issue or PR has been inactive for a while label Aug 14, 2024
@github-actions
Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale This issue or PR has been inactive for a while label Sep 13, 2024
@ed7ed
Copy link
Copy Markdown

ed7ed commented Sep 30, 2024

+1. I've got the same problem. Applying this patch works for me without any issues so far. @folke can you merge it pls?

@github-actions github-actions bot removed the stale This issue or PR has been inactive for a while label Oct 1, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 1, 2024

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale This issue or PR has been inactive for a while label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale This issue or PR has been inactive for a while

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Switching buffers while in ZenMode doesn't apply ZenMode options

3 participants