This repository was archived by the owner on Oct 27, 2024. It is now read-only.
Improved Exception handling#19
Open
JagexJenesis wants to merge 2 commits intoforetagsplatsen:masterfrom
Open
Conversation
…eption. This makes it simpler for code calling into Divan to catch any errors thrown, and means that errors thrown will be consistent in whether they contain a StatusCode.
…hat we now receive a CouchConflictException rather than an error about the JSON object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi guys,
Thanks for sharing Divan with the world, it's made working with Couch for the first time much less difficult than it might have been. While I was still getting to grips with Couch and doing many things wrong, I found that the way Divan deals with Couch errors wasn't what I expected, and could perhaps be improved. I'm now sharing those changes with you for potential inclusion in the mainline. Jagex is happy for this code to be shared under the MIT License.
Thanks again,
Chris Knowles