Skip to content

fix: segfault after unrecognised moduleoption #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jodavies wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: segfault after unrecognised moduleoption #817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions check/fixes.frm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4437,6 +4437,13 @@ assert result("testCF1") =~ expr("putfirst_(f,2,mu1)*putfirst_(e,2,mu1)*putfirst
assert result("testCF2") =~ expr("d(mu2,mu1)*e(mu2,mu1)*f(mu2,mu1)")
assert result("testCF3") =~ expr("d(mu2,mu1,mu3)*e(mu2,mu1,mu3)*f(mu2,mu1,mu3)")
*--#] Issue750 :
*--#[ Issue760 :
ModuleOption foo;
ModuleOption parallel,foo;
ModuleOption foo,parallel;
.end
assert preprocess_error?("Unrecognized module option: foo")
Copy link
Copy Markdown
Collaborator

@tueda tueda Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test must produce 3 errors. Perhaps, it would be good to check if all the cases actually result in errors (e.g., foo1, foo2 and foo3).

*--#] Issue760 :
*--#[ Issue766 :
* Unintended "&" in some warning messages
CF f(s,s);
Expand Down
1 change: 1 addition & 0 deletions sources/module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ int CoModuleOption(UBYTE *s)
SKIPBLANKS(t)
if ( (option->func)(t) ) error = 1;
}
if ( error ) return(error);
if ( StrCmp((UBYTE *)(option->name),(UBYTE *)("polyfun")) == 0
|| StrCmp((UBYTE *)(option->name),(UBYTE *)("polyratfun")) == 0 ) {
polyflag = 1;
Expand Down
Loading