Skip to content

Improve failure info in mappings#609

Open
filipeom wants to merge 1 commit intomainfrom
filipe/better-debug-info
Open

Improve failure info in mappings#609
filipeom wants to merge 1 commit intomainfrom
filipe/better-debug-info

Conversation

@filipeom
Copy link
Copy Markdown
Member

No description provided.

@filipeom filipeom requested a review from a team as a code owner April 28, 2026 11:10
@redianthus
Copy link
Copy Markdown
Contributor

redianthus commented Apr 28, 2026

This is great but I feel like you could maybe avoid getting in the trouble of adding this everywhere by either running OCAMLRUNPARAM=b whatever.exe which should display a backtrace, or simply conditionally turn the backtrace recording on from the OCaml side (doing it unconditionally will hurt performances so we should avoid it).

Or is there something better with the approach in the current PR?

(In any case, I don't really mind, this was more a suggestion :))

@filipeom
Copy link
Copy Markdown
Member Author

It was mostly to avoid hardcoding stuff like: "Bitwuzla_mappings: Int.lt not implemented" because when I copy paste the failure strings I sometimes forget to update it and then it leads to some confusing messages 😅 But yeah, the backtrace is what I rely on mostly 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants