Add workflow to check E2E tests pass before publishing#74
Closed
jovnc wants to merge 1 commit intogit-mastery:mainfrom
Closed
Add workflow to check E2E tests pass before publishing#74jovnc wants to merge 1 commit intogit-mastery:mainfrom
jovnc wants to merge 1 commit intogit-mastery:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a gating job to the release/publish workflow so publishing only proceeds after the repository’s E2E test workflow has passed for the commit being released.
Changes:
- Add a
check-e2ejob that queries GitHub Actions runs viagh run listand aborts if E2E did not succeed. - Update platform build jobs to require
check-e2e(in addition toprepare) before they run.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+27
to
+30
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| gh run list --repo ${{ github.repository }} --workflow test.yml --commit ${{ github.sha }} --status success --json conclusion --jq '.[0].conclusion' | grep -q success || (echo "E2E tests have not passed for commit ${{ github.sha }}. Publish aborted." && exit 1) |
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| gh run list --repo ${{ github.repository }} --workflow test.yml --commit ${{ github.sha }} --status success --json conclusion --jq '.[0].conclusion' | grep -q success || (echo "E2E tests have not passed for commit ${{ github.sha }}. Publish aborted." && exit 1) |
Comment on lines
+24
to
+30
|
|
||
| steps: | ||
| - name: Check E2E test status for tagged commit | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| gh run list --repo ${{ github.repository }} --workflow test.yml --commit ${{ github.sha }} --status success --json conclusion --jq '.[0].conclusion' | grep -q success || (echo "E2E tests have not passed for commit ${{ github.sha }}. Publish aborted." && exit 1) |
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| gh run list --repo ${{ github.repository }} --workflow test.yml --commit ${{ github.sha }} --status success --json conclusion --jq '.[0].conclusion' | grep -q success || (echo "E2E tests have not passed for commit ${{ github.sha }}. Publish aborted." && exit 1) |
Comment on lines
+21
to
38
| check-e2e: | ||
| name: Verify E2E tests passed | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Check E2E test status for tagged commit | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| gh run list --repo ${{ github.repository }} --workflow test.yml --commit ${{ github.sha }} --status success --json conclusion --jq '.[0].conclusion' | grep -q success || (echo "E2E tests have not passed for commit ${{ github.sha }}. Publish aborted." && exit 1) | ||
|
|
||
| prepare: | ||
| uses: git-mastery/actions/.github/workflows/get-latest-tag.yml@main | ||
| secrets: inherit | ||
|
|
||
| linux-build: | ||
| needs: prepare | ||
| needs: [prepare, check-e2e] | ||
| if: needs.prepare.outputs.should_publish == 'true' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #66
gh runs listto check status of E2E tests