Skip to content

chore: relint, tests, doc, ci#164

Merged
fredbi merged 4 commits intogo-openapi:masterfrom
fredbi:test/upgrade-testify-with-generics
Mar 3, 2026
Merged

chore: relint, tests, doc, ci#164
fredbi merged 4 commits intogo-openapi:masterfrom
fredbi:test/upgrade-testify-with-generics

Conversation

@fredbi
Copy link
Member

@fredbi fredbi commented Mar 3, 2026

Maintenance work.

  • test: upgraded testify/v2, migrated to generic assertions, refactored JSON assertions to leverage testify/v2.4.0
  • test(internal/testintegration): re-enacted integration tests as a separate module. The repo thus moves technically to a mono-repo (with committed go.work). Moved the big Azure spec fixture to integration tests.
  • ci: switched to mono repo workflows, removed local git-cliff config
  • doc: fixed godoc formatting
  • doc: fixed discord link

Change type

Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update

Short description

Fixes

Full description

Checklist

  • I have signed all my commits with my name and email (see DCO. This does not require a PGP-signed commit
  • I have rebased and squashed my work, so only one commit remains
  • I have added tests to cover my changes.
  • I have properly enriched go doc comments in code.
  • I have properly documented any breaking change.

@fredbi fredbi force-pushed the test/upgrade-testify-with-generics branch from 13898cb to 1d97e19 Compare March 3, 2026 12:03
Maintenance work.

* test: upgraded testify/v2, migrated to generic assertions, refactored
  JSON assertions to leverage testify/v2.4.0
* test(internal/testintegration): re-enacted integration tests as a separate
  module. The repo thus moves technically to a mono-repo (with committed
  go.work). Moved the big Azure spec fixture to integration tests.
* ci: switched to mono repo workflows, removed local git-cliff config
* doc: fixed godoc formatting
* doc: fixed discord link

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi fredbi force-pushed the test/upgrade-testify-with-generics branch from 1d97e19 to 6f494bc Compare March 3, 2026 12:52
fredbi and others added 3 commits March 3, 2026 14:51
Sort map keys before iterating over newRefs in stripOAIGen and
stripOAIGenForRef to avoid non-deterministic behavior caused by
Go 1.26's Swiss Tables map implementation.

Also ensures spec analysis is refreshed before stripping OAIGen
refs and propagates parent tracking when target refs are themselves
OAIGen entries.

Co-Authored-By: Felix Kollmann <mail@fkollmann.de>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.54%. Comparing base (3beae5a) to head (a39d677).
⚠️ Report is 14 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
flatten.go 75.00% 4 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (76.19%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
- Coverage   91.67%   91.54%   -0.13%     
==========================================
  Files          17       17              
  Lines        2017     2034      +17     
==========================================
+ Hits         1849     1862      +13     
- Misses        111      114       +3     
- Partials       57       58       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredbi fredbi merged commit 18e543f into go-openapi:master Mar 3, 2026
19 of 21 checks passed
@fredbi fredbi deleted the test/upgrade-testify-with-generics branch March 3, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant