fix issue #69#78
Open
vaporz wants to merge 2 commits intogocraft:masterfrom
Open
Conversation
shdunning
reviewed
Dec 13, 2017
| } | ||
| if jt, ok := w.jobTypes[job.Name]; ok { | ||
| if jt.StartingDeadline > 0 && job.ScheduledAt > 0 && job.ScheduledAt < jt.StartingDeadline { | ||
| logInfo("Outdated! StartingDeadline: %d, ScheduledAt: %d, Job: %s\n", jt.StartingDeadline, job.ScheduledAt, job) |
Collaborator
There was a problem hiding this comment.
We don't want to be logging info messages in the middle of a job processing loop - please remove this (it's not bad thing to have for running the tests).
shdunning
reviewed
Dec 13, 2017
| SkipDead bool // If true, don't send failed jobs to the dead queue when retries are exhausted. | ||
| MaxConcurrency uint // Max number of jobs to keep in flight (default is 0, meaning no max) | ||
| Backoff BackoffCalculator // If not set, uses the default backoff algorithm | ||
| StartingDeadline int64 // UTC time in seconds(time.Now().Unix()), the deadline for starting the job if it misses its scheduled time for any reason |
Collaborator
There was a problem hiding this comment.
Where is this set? Is the client code's responsibility?
Contributor
Author
There was a problem hiding this comment.
It is set when a job is registered in worker pool, before the pool is started.
Contributor
Author
|
@shdunning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix issue #69 .