Fix JSON-RPC request error handling and pending request cleanup#219
Open
gioalex07 wants to merge 2 commits intogogcom:masterfrom
Open
Fix JSON-RPC request error handling and pending request cleanup#219gioalex07 wants to merge 2 commits intogogcom:masterfrom
gioalex07 wants to merge 2 commits intogogcom:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a few issues in the JSON-RPC layer that could affect plugin stability, especially around internal
requests like
refresh_credentials().What Changed
InvalidParamsfor requests with bad arguments_requests_futuresentries after handling a responseJsonRpcErrorrefresh_credentials()on closeRoot Cause
There were three related problems in
jsonrpc.py:bound_argseven when binding hadfailed.
_requests_futures, even after receiving a response or closingthe connection.
JsonRpcError, which discarded the original application-specific error type.
Impact
These issues could lead to:
UnboundLocalErrorafterInvalidParams_requests_futuresrefresh_credentials()Validation
Validated with targeted local reproductions covering:
Notes
This PR is intentionally limited to the JSON-RPC layer and regression coverage around it.