Remove unused field descriptor argument from CGPToReflectionType functions.#2712
Open
copybara-service[bot] wants to merge 1 commit intomasterfrom
Open
Remove unused field descriptor argument from CGPToReflectionType functions.#2712copybara-service[bot] wants to merge 1 commit intomasterfrom
copybara-service[bot] wants to merge 1 commit intomasterfrom
Conversation
…tions. The CGPToReflectionType helper functions in Descriptors_PackagePrivate.h no longer take a CGPFieldDescriptor argument, as it was not used in most type conversions. The enum conversion and CGPEnumGetIntValue now use the getValueDescriptor method on the enum value instead of unsightly pointer math. PiperOrigin-RevId: 900358216
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused field descriptor argument from CGPToReflectionType functions.
The CGPToReflectionType helper functions in Descriptors_PackagePrivate.h no longer take a CGPFieldDescriptor argument, as it was not used in most type conversions. The enum conversion and CGPEnumGetIntValue now use the getValueDescriptor method on the enum value instead of unsightly pointer math.