Refactor: Use specific type for enum values in protobuf runtime.#2718
Open
copybara-service[bot] wants to merge 1 commit intomasterfrom
Open
Refactor: Use specific type for enum values in protobuf runtime.#2718copybara-service[bot] wants to merge 1 commit intomasterfrom
copybara-service[bot] wants to merge 1 commit intomasterfrom
Conversation
This change introduces a dedicated `valueEnum` field in `CGPValue` to store enum instances as `JavaLangEnum<ComGoogleProtobufProtocolMessageEnum> *` instead of the generic `id`. This improves type safety and clarity in handling enum values across the protobuf runtime, including descriptor handling, message serialization/deserialization, and map field comparisons. PiperOrigin-RevId: 900792436
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: Use specific type for enum values in protobuf runtime.
This change introduces a dedicated
valueEnumfield inCGPValueto store enum instances asJavaLangEnum<ComGoogleProtobufProtocolMessageEnum> *instead of the genericid. This improves type safety and clarity in handling enum values across the protobuf runtime, including descriptor handling, message serialization/deserialization, and map field comparisons.