Refactor protobuf repeated field additions to use TYPE_ASSIGN macros.#2720
Open
copybara-service[bot] wants to merge 1 commit intomasterfrom
Open
Refactor protobuf repeated field additions to use TYPE_ASSIGN macros.#2720copybara-service[bot] wants to merge 1 commit intomasterfrom
copybara-service[bot] wants to merge 1 commit intomasterfrom
Conversation
Removes the TYPE_RETAIN_* macros and updates repeated field addition logic in GeneratedMessage.mm and RepeatedField.m to use the existing TYPE_ASSIGN_* macros. This simplifies the type handling by centralizing retain/release logic within the TYPE_ASSIGN macros. It does add an extra unneeded AUTORELEASE call at those assign locations, but I feel that removing the memory complexity is worth it. PiperOrigin-RevId: 901337957
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor protobuf repeated field additions to use TYPE_ASSIGN macros.
Removes the TYPE_RETAIN_* macros and updates repeated field addition logic in GeneratedMessage.mm and RepeatedField.m to use the existing TYPE_ASSIGN_* macros. This simplifies the type handling by centralizing retain/release logic within the TYPE_ASSIGN macros. It does add an extra unneeded AUTORELEASE call at those assign locations, but I feel that removing the memory complexity is worth it.