Skip to content

Set heap size flags in nomulus start script#2956

Merged
jicelhay merged 4 commits intogoogle:masterfrom
jicelhay:heapmemory
Feb 13, 2026
Merged

Set heap size flags in nomulus start script#2956
jicelhay merged 4 commits intogoogle:masterfrom
jicelhay:heapmemory

Conversation

@jicelhay
Copy link
Collaborator

@jicelhay jicelhay commented Feb 11, 2026

With these changes we are explicitly setting heap sizes in relation to container's memory limit.

Max heap was defaulting to 25%, which isn't optimal for our settings (one-ish app per container).

b/468369756


This change is Reviewable

@jicelhay jicelhay requested a review from CydeWeys February 12, 2026 19:58
Copy link
Member

@CydeWeys CydeWeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CydeWeys made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @jicelhay).


jetty/start.sh line 31 at r1 (raw file):

esac
java $PROFILER_ARGS \
    -XX:InitialRAMPercentage=50.0 \

Add a comment here explaining the reasoning behind 50%? (In particular, how we only run 1 Java instance per container, or whatever the exact finding was.)

Copy link
Member

@CydeWeys CydeWeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CydeWeys reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jicelhay).

Copy link
Collaborator Author

@jicelhay jicelhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jicelhay resolved 1 discussion.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @CydeWeys).

@jicelhay jicelhay enabled auto-merge February 13, 2026 20:22
Copy link
Member

@CydeWeys CydeWeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CydeWeys reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jicelhay).

@jicelhay jicelhay added this pull request to the merge queue Feb 13, 2026
Merged via the queue into google:master with commit bca05f3 Feb 13, 2026
10 checks passed
@jicelhay jicelhay deleted the heapmemory branch February 13, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants