Move //:config to implementation_deps to prevent header collision#229
Merged
danilak-G merged 1 commit intogoogle:mainfrom Mar 6, 2026
Merged
Move //:config to implementation_deps to prevent header collision#229danilak-G merged 1 commit intogoogle:mainfrom
//:config to implementation_deps to prevent header collision#229danilak-G merged 1 commit intogoogle:mainfrom
Conversation
Contributor
Author
|
@danilak-G I don't think this change would negatively impact Google as I don't expect the generated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snappy's
//:configtarget exposesconfig.hviahdrsand definesHAVE_CONFIG_H. Whenever//:snappyis in the dependency graph of any othercc_*target it results in snappy'sconfig.hbeing added as an available header to compile actions. This leads to a header collision and breaks consumers. By moving//:configto implementation_deps the header is not propagated and the collision is avoided.