Add support for structured dtypes to zarr3 driver, open structs as void#271
Open
BrianMichell wants to merge 123 commits intogoogle:masterfrom
Open
Add support for structured dtypes to zarr3 driver, open structs as void#271BrianMichell wants to merge 123 commits intogoogle:masterfrom
zarr3 driver, open structs as void#271BrianMichell wants to merge 123 commits intogoogle:masterfrom
Conversation
…t for raw bits dtype
Implement shim for `open_as_void` driver level flag
* Begin removing void field shim * Fully removed void string shim * Cleanup debug prints * Remove shimmed validation * Remove unnecessary comment * Prefer false over zero for ternary clarity
* Implement a more general and portable example set * Fix driver cache bug * Update example for template * Cleanup example * Remove testing examples from source
* Use the appropriate fill value for open_as_void structured data * Cleanup
Collaborator
|
I'll try to get to this in about a week, before I look this one over, please double check that the prior PR works for you. Also look over this one and see if any of the suggestions from the other one applies. |
Matches the pattern from zarr v2 driver (PR google#272). When both "field" and "open_as_void" are specified in the spec, return an error since these options are mutually exclusive - field selects a specific field from a structured array, while open_as_void provides raw byte access to the entire structure.
The zarr3 URL syntax cannot represent field selection or void access mode. Following the pattern from zarr v2 driver (PR google#272), ToUrl() now returns an error when either of these options is specified instead of silently ignoring them.
…trip Following the pattern from zarr v2 driver (PR google#272), override GetBoundSpecData in ZarrDataCache to set spec.open_as_void from ChunkCacheImpl::open_as_void_. This ensures that when you open a store with open_as_void=true and then call spec(), the resulting spec correctly has open_as_void=true set. Without this fix, opening a store with open_as_void=true and then getting its spec would lose the open_as_void flag, causing incorrect behavior if the spec is used to re-open the store.
laramiel
reviewed
Mar 26, 2026
laramiel
reviewed
Mar 26, 2026
laramiel
reviewed
Mar 26, 2026
laramiel
reviewed
Mar 26, 2026
laramiel
reviewed
Mar 26, 2026
laramiel
reviewed
Mar 26, 2026
laramiel
reviewed
Mar 26, 2026
laramiel
reviewed
Mar 26, 2026
Collaborator
|
Ok, I think that I'm running out of things to point out. We may want to wait for @jbms to look at it again and see what he sees; he may be out for a week or so. |
laramiel
reviewed
Mar 30, 2026
laramiel
reviewed
Mar 30, 2026
laramiel
reviewed
Mar 30, 2026
laramiel
reviewed
Mar 30, 2026
laramiel
reviewed
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #264
Resolves comments 1 and 2