Allow non-Comparable subjects to be compared using an explicit Comparator#191
Open
benblank wants to merge 2 commits intogoogle:masterfrom
Open
Allow non-Comparable subjects to be compared using an explicit Comparator#191benblank wants to merge 2 commits intogoogle:masterfrom
benblank wants to merge 2 commits intogoogle:masterfrom
Conversation
Member
|
Hey Ben, Thanks for sending this over...we've been trying to gauge interest in a similar API internally for a few months now. Here are some questions we had from our discussions:
We've spent a good deal of time discussing this...now we just need to do some research over the Google codebase to figure out if this will be generally useful for people. Thanks, |
Member
|
/cc @PeteGillin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows a subject with an arbitrary type to be treated as a "faux"
Comparable, with propositions similar to those provided to aComparableSubject.FauxComparabledeliberately does not extendSubject, to prevent meaningless (and potentially confusing) constructs likeassertThat(a).whenComparedUsing(comparator).isNotNull();. (This is broadly similar toOrdered.)Implementing
.whenComparedUsing()also required parameterizingDefaultSubject, so that type checking can be done on the suppliedComparator.